Fix CORS with public pages #36399
Closed
Fix CORS with public pages #36399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Rittershofer <[email protected]>
Member
Author
|
\backport to stable25 |
Member
Author
|
Dang, just saw #36396 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The combination of Annotations
CORSandPublicPageon API-Routines currently disables the CORS Login. I assume, this once was a simple fix to disable the authentication necessity on public pages. Since the CORS-Routine now allows to continue, if the CSRFCheck passes, this is not necessary anymore.-> Like this, PublicPages work by the CSRF-token
-> CORS Requests work by basic auth.
Checklist