Skip to content

fix(updater): Don't warn about missing appstore updates for apps depl… #36486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Feb 24, 2023
Merged

fix(updater): Don't warn about missing appstore updates for apps depl… #36486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(updater): Don't warn about missing appstore updates for apps depl… 
…oyed from git

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Feb 1, 2023
commit bde109d1581bd9fcdc64fe65796f8b610740059e
9 changes: 9 additions & 0 deletions apps/updatenotification/lib/Controller/APIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ public function getAppList(string $newVersion): DataResponse {

$this->language = $this->l10nFactory->getUserLanguage($this->userSession->getUser());

// Ignore apps that are deployed from git
$installedApps = array_filter($installedApps, function(string $appId) {
try {
return !file_exists($this->appManager->getAppPath($appId) . '/.git');
} catch (AppPathNotFoundException $e) {
return true;
}
});

$missing = array_diff($installedApps, $availableApps);
$missing = array_map([$this, 'getAppDetails'], $missing);
sort($missing);
Expand Down