Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 2, 2023

Since PHPUnit 9.5 this test fails. However the function is so plain:

public function isSystemWideMountPoint(string $path, string $uid) {
$mount = Filesystem::getMountManager()->find('/' . $uid . $path);
return $mount instanceof ISystemMountPoint;
}

That testing it with mocks doesn't really make a lot of sense.

Checklist

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 2, 2023
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Feb 2, 2023
@nickvergessen nickvergessen requested review from a team, come-nc and icewind1991 February 2, 2023 17:06
@nickvergessen nickvergessen self-assigned this Feb 2, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl and removed request for a team February 2, 2023 17:06
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish technical debt and removed 3. to review Waiting for reviews labels Feb 2, 2023
@nickvergessen nickvergessen merged commit 08bfe64 into master Feb 3, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/remove-failing-test branch February 3, 2023 08:28
@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen
Copy link
Member Author

@blizzz blizzz mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants