[stable25] Fix compilation of Vue 2.7 features #36624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
:deep()selector, introduced in Vue 2.7 alongside the deprecation of::v-deepand subsequent un-deprecation in this commit vuejs/vue@2f335b2 released in Vue 2.7.11 https://github.com/vuejs/vue/blob/main/CHANGELOG.md#2711-2022-10-11, was not being compiled correctly and resulted in incorrect CSS outputWe must explicitly bump
vue-loaderto15.10.1onstable25as https://github.com/vuejs/vue-loader/releases/tag/v15.10.0 introduced support for Vue 2.7This is needed on
stable25but notmasteras although both havevue-loader15.9.8server/package.json
Line 143 in d60fd2c
server/package.json
Line 167 in 08802ad
@nextcloud/webpack-vue-configis presentserver/package.json
Line 122 in 08802ad
masterwhich results invue-loaderbeing deduped to15.10.1This fixes the contacts menu styles
Checklist