Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 11, 2023

Manual backport of #36443

@szaimen szaimen added bug 3. to review Waiting for reviews labels Feb 11, 2023
@szaimen szaimen added this to the Nextcloud 25.0.5 milestone Feb 11, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, ChristophWurst, blizzz, icewind1991 and nickvergessen and removed request for a team February 11, 2023 13:29
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block merges during feature freezes

Has to wait until Thursday+

@szaimen
Copy link
Contributor Author

szaimen commented Feb 24, 2023

CI failure unrelated

@szaimen szaimen merged commit 2f5d8f8 into stable25 Feb 24, 2023
@szaimen szaimen deleted the backport/36443/stable25 branch February 24, 2023 09:19
@TomW80
Copy link

TomW80 commented Feb 28, 2023

Hello,

I have now updated to NC 25.0.4 and tested the login with php8.
I get again an error from LoginController:

[index] Fehler: Exception: OC\Core\Controller\LoginController::tryLogin(): Argument #1 ($user) must be of type string, null given, called in /volume1/web/nextcloud/lib/private/AppFramework/Http/Dispatcher.php on line 225 in file '/volume1/web/nextcloud/core/Controller/LoginController.php' line 298 at <<closure>>

0. /volume1/web/nextcloud/lib/private/AppFramework/App.php line 172
   OC\AppFramework\Http\Dispatcher->dispatch(["OC\\Core\\Controller\\LoginController"], "tryLogin")
1. /volume1/web/nextcloud/lib/private/Route/Router.php line 298
   OC\AppFramework\App::main("OC\\Core\\Controller\\LoginController", "tryLogin", ["OC\\AppFramewo ... "], ["core.login.tryLogin"])
2. /volume1/web/nextcloud/lib/base.php line 1047
   OC\Route\Router->match("/login")
3. /volume1/web/nextcloud/index.php line 36
   OC::handleRequest()

and this Error:

[PHP] Fehler: Unknown: POST Content-Length of 185 bytes exceeds the limit of 2 bytes at Unknown#0

@szaimen
Copy link
Contributor Author

szaimen commented Feb 28, 2023

Hi, yes the PR will be included in 25.0.5

@blizzz blizzz mentioned this pull request Mar 13, 2023
@TomW80
Copy link

TomW80 commented Apr 9, 2023

Hello,

I have now updated to NC 25.0.5 and tested login with php8.
Error from LoginController is solved, but when I login I am always redirected back to the login page and still get this error:

Unknown: POST Content-Length of 196 bytes exceeds the limit of 2 bytes at Unknown#0.

@nickvergessen
Copy link
Member

Sounds like you are missing an M or G in your php.ini config and just set the post/upload max size to 2 Bwhich is 2 bytes instead of 2 MB

@TomW80
Copy link

TomW80 commented Apr 12, 2023

You are right, at post max size I had written 2GB.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants