feat(dav): Directly access shared calendars by URI #36681
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time we access a shared calendar details (with getChild), this loads every user's calendars and iterates until the correct one is found. Now we lookup from the shared calendars which ones has the correct URI, just iterating on the possible shares (for instance a calendar can be shared directly through user-to-user share or through user-to-group share). Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
2. developing
tcitworld
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| $readOnly = (int)$row['access'] === Backend::ACCESS_READ; | ||
| if (isset($calendars[$row['id']])) { |
Check failure
Code scanning / Psalm
UndefinedVariable
| } | ||
|
|
||
| // Fixes for shared calendars | ||
| [, $name] = Uri\split($row['principaluri']); |
Check failure
Code scanning / Psalm
UndefinedFunction
| $readOnlyPropertyName => $readOnly, | ||
| ]; | ||
| } | ||
| $calendar = $this->rowToCalendar($row, $calendar); |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable
| $readOnlyPropertyName => $readOnly, | ||
| ]; | ||
| } | ||
| $calendar = $this->rowToCalendar($row, $calendar); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time we access a shared calendar details (with getChild), this loads every user's calendars and iterates until the correct one is found. Now we lookup from the shared calendars which ones has the correct URI, just iterating on the possible shares (for instance a calendar can be shared directly through user-to-user share or through user-to-group share).
Didn't mesure properly the performance benefits, but should be really nice with many shared calendars.
Follow-up to #33608
TODO
Checklist