Skip to content

fix(preview-generator): Throw exception before dividing by zero when generating previews #36692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
May 16, 2023
Merged

fix(preview-generator): Throw exception before dividing by zero when generating previews #36692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(preview-generator): Throw exception before dividing by zero when … 
…generating previews

If the maximum preview generated gives some kind of invalid IImage, it's dimentions and filename can be set to zero.
And then later we do a division by zero to keep the aspect ratio of the previews.

Signed-off-by: Thomas Citharel <[email protected]>
  • Loading branch information
@tcitworld
tcitworld committed Feb 13, 2023
commit e60888d98892be22477ea6ace68255d7202dbec8
4 changes: 4 additions & 0 deletions lib/private/Preview/Generator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ public function generatePreviews(File $file, array $specifications, $mimeType =

[$maxWidth, $maxHeight] = $this->getPreviewSize($maxPreview, $previewVersion);

if ($maxWidth <= 0 || $maxHeight <= 0) {
throw new NotFoundException('The maximum preview sizes are zero or less pixels');
}

$preview = null;

foreach ($specifications as $specification) {
Expand Down