-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add parent index on filecache #36701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable25 |
|
/backport to stable24 |
icewind1991
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs to be added to the migration that creates the filecache table
32bbce6 to
407ff41
Compare
|
Waiting for more practical feedbacks before moving on. |
|
Can you outline or do you have a reference why the single index would be faster? At least from the explain there seems to be no difference. |
It seems that the size of the parent_name_hash index is causing performance issues |
|
/rebase |
Signed-off-by: Louis Chemineau <[email protected]>
407ff41 to
bda66f9
Compare
|
Failure unrelated |
|
/backport to stable26 |
To speed up:
server/lib/private/Files/Cache/Cache.php
Lines 878 to 880 in fd2afe6
The current query uses the
parent_name_hashindex, which is not optimal with long names.