Bump @nextcloud/dialogs from 4.0.0-beta.2 to 4.0.1

[Pytal]

Summary

Bump @nextcloud/dialogs from https://github.com/nextcloud/nextcloud-dialogs/releases/tag/v4.0.0-beta.2 to https://github.com/nextcloud/nextcloud-dialogs/releases/tag/v4.0.1

Related

• Bump @nextcloud/vue from 7.5.0 to 7.6.0 #36739

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Pytal]

🤔 This bump alone results in many OC is not defined and process is not defined errors and neither npm i process nor setting resolve.alias.process = 'process/browser' resolves the errors

There are no errors coming from packages so this is probably a result of the core script loading or load order logic, would a dev familiar with the script load logic https://github.com/nextcloud/server/blame/d33fbbed1d20496387decde205f7cac9913b3421/lib/public/Util.php#L173-L217 be able to decipher these errors @mejo-?

[Pytal]

Checked the Network tab in devtools and all scripts are loaded in the exact same order as working master

Went through the package changes in nextcloud-libraries/nextcloud-dialogs@v4.0.0-beta.2...v4.0.1 and cannot find a culprit

So currently out of ideas, does anything stand out to you @artonge?

[artonge]

I would look into the first error process is not defined from:

OC/util.js --> @nextcloud/files --> path --> process.platform === 'win32'

This is preventing OC from being defined.

Not sure why the error is being triggered now, maybe a change in the bundle order moved the initialization, and therefore error, in this code path, making it apparent.

Not familiar enough with modules, but we definitely need to use a browser compatible path module. The currently used one is for Node. From path-browserify, it seems like bundlers like webpack automatically use it when importing path. Perhaps we need to configure rollup in @nextcloud/files to have the same behaviour.

[Pytal]

Superseded by nextcloud-libraries/nextcloud-vue#3772 and #36813