Avoid scss cacher reset on empty variables #36762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
bugfix/noid/scss-reset
branch
from
23ce745 to
077396a
Compare
juliusknorr
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
juliusknorr
force-pushed
the
bugfix/noid/scss-reset
branch
from
077396a to
f40e354
Compare
icewind1991
approved these changes
Feb 21, 2023
marcelklehr
approved these changes
Feb 24, 2023
skjnldsv
approved these changes
Feb 24, 2023
Member
Author
|
/rebase |
Signed-off-by: Julius Härtl <[email protected]>
nextcloud-command
force-pushed
the
bugfix/noid/scss-reset
branch
from
f40e354 to
a04ed00
Compare
Member
Author
|
Failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed cases where the variables were empty on unrelated requests by random security scanners, which triggered random cache invalidation and scss regeneration.
Only relevant for 24 as SCSS cacher was dropped with 25.