fix: always use proper path on node api when calling the view

[juliusknorr]

Make sure that the nodes API always uses the full path and root view.

This is only noticeable on places where the dav app already uses the new nodes api but could cause trouble in the future.

Seen this being an issue when the dav app passes a relative path and fake root view for the user but the full file system setup was dropped by #36589 when:

• Incoming share was moved to a subfolder A/B/share
• Perform the following query: curl -X PROPFIND http://admin:[email protected]/remote.php/webdav/A -H 'Depth: 2'

[miaulalala]

Makes sense to me but I'm no expert.

[come-nc]

Does that fix #34932 (comment) ?

[juliusknorr]

Does that fix #34932 (comment) ?

Not directly I think, but we could probably refactor to just avoid using the View in

server/apps/dav/lib/Connector/Sabre/Directory.php

Lines 115 to 151 in 5d4efb4

	try {
	// For non-chunked upload it is enough to check if we can create a new file
	if (!$this->fileView->isCreatable($this->path)) {
	throw new Exception\Forbidden();
	}
	$this->fileView->verifyPath($this->path, $name);
	$path = $this->fileView->getAbsolutePath($this->path) . '/' . $name;
	// in case the file already exists/overwriting
	$info = $this->fileView->getFileInfo($this->path . '/' . $name);
	if (!$info) {
	// use a dummy FileInfo which is acceptable here since it will be refreshed after the put is complete
	$info = new \OC\Files\FileInfo($path, null, null, [
	'type' => FileInfo::TYPE_FILE
	], null);
	}
	$node = new \OCA\DAV\Connector\Sabre\File($this->fileView, $info);
	// only allow 1 process to upload a file at once but still allow reading the file while writing the part file
	$node->acquireLock(ILockingProvider::LOCK_SHARED);
	$this->fileView->lockFile($path . '.upload.part', ILockingProvider::LOCK_EXCLUSIVE);
	$result = $node->put($data);
	$this->fileView->unlockFile($path . '.upload.part', ILockingProvider::LOCK_EXCLUSIVE);
	$node->releaseLock(ILockingProvider::LOCK_SHARED);
	return $result;
	} catch (StorageNotAvailableException $e) {
	throw new ServiceUnavailable($e->getMessage());
	} catch (InvalidPathException $ex) {
	throw new InvalidPath($ex->getMessage(), false, $ex);
	} catch (ForbiddenException $ex) {
	throw new Forbidden($ex->getMessage(), $ex->getRetry(), $ex);
	} catch (LockedException $e) {
	throw new FileLocked($e->getMessage(), $e->getCode(), $e);
	}

and go directly through the Nodes API instead. This would get rid of the separate handling of hooks in this case in the dav app.

[icewind1991]

Sabre\Node::refreshInfo will also need updating.

Overall the change is the right direction imo, and ensuring some consistency here should also make an eventual move to using the Node api directly a bit easier

Addressed

[nickvergessen]

I think we have to revert #36589 because it causes a major regression with Talk/ attachment handling, see #36787

I also tested with this PR here and Talk/ is still not working. Given that we are behind feature freeze I vote to delay this here, revert the other PR on master until stable26 is branched off and try again for 27.l

[nickvergessen]

blocking as per above

[juliusknorr]

Dry run of talk integration tests passes nextcloud/spreed#9173

Failing PR was reverted, this change is still good besides that for 27 now.

[icewind1991]

/backport to stable26

[icewind1991]

/backport to stable25