Revert "fix(performance): Do not set up filesystem on every call" #36788
Conversation
nickvergessen
commented
Feb 21, 2023
nickvergessen
commented
- Reverts fix(performance): Do not set up filesystem on every call #36589
- Details in Regression in filesystem handling breaks Talk/ attachment folder #36787
nickvergessen
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new NotImplemented($this->l10n->t('Invalid chunk name')); | ||
| } | ||
|
|
||
| $chunk_handler = new \OC_FileChunking($info); |
Check notice
Code scanning / Psalm
UndefinedFunction
| $targetPath = $path . '/' . $info['name']; | ||
| /** @var \OC\Files\Storage\Storage $targetStorage */ | ||
| [$targetStorage, $targetInternalPath] = $this->fileView->resolvePath($targetPath); | ||
|
|
Check notice
Code scanning / Psalm
DeprecatedClass
| $this->fileView->unlockFile($targetPath, ILockingProvider::LOCK_SHARED); | ||
|
|
||
| return $info->getEtag(); | ||
| } catch (\Exception $e) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| $this->fileView->unlockFile($targetPath, ILockingProvider::LOCK_SHARED); | ||
|
|
||
| return $info->getEtag(); | ||
| } catch (\Exception $e) { |
Check notice
Code scanning / Psalm
PossiblyFalseReference
| } | ||
| $this->convertToSabreException($e); | ||
| } | ||
| } |
Check notice
Code scanning / Psalm
PossiblyFalseReference
| // chunked upload handling | ||
| if (isset($_SERVER['HTTP_OC_CHUNKED'])) { | ||
| [$path, $name] = \Sabre\Uri\split($filePath); | ||
| $info = \OC_FileChunking::decodeName($name); |
Check notice
Code scanning / Psalm
UndefinedFunction
| $dir = ''; | ||
| } | ||
|
|
||
| $info = \OC_FileChunking::decodeName($name); |
Check notice
Code scanning / Psalm
UndefinedFunction
| return true; | ||
| } | ||
|
|
||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingReturnType
| return true; | ||
| } | ||
|
|
||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingParamType
