Skip to content

do onetime user setup before getting any mount from providers #36810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icewind1991 merged 1 commit into from
Mar 24, 2023
Merged

do onetime user setup before getting any mount from providers #36810

icewind1991 merged 1 commit into from
Mar 24, 2023

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Feb 22, 2023

this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily

To test:

  • Setup an instance with encryption enabled, groupfolders and text
  • Enable groupfolder encryption: occ config:app:set groupfolders enable_encryption --value true
  • Create a groupfolder and navigate into it
  • Click the "Add notes, lists, or links..." in the webui to create a Readme.md in the folder
  • Check if the text editor gets filled with an encrypted blob or an empty textfile

@icewind1991
do onetime user setup before getting any mount from providers
fb1095f 
this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 22, 2023
@icewind1991 icewind1991 added this to the Nextcloud 26 milestone Feb 22, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and come-nc and removed request for a team February 22, 2023 17:06
@icewind1991 icewind1991 marked this pull request as ready for review February 22, 2023 17:13
@icewind1991
Copy link
Member Author

icewind1991 commented Feb 22, 2023

/backport to stable25

@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

/backport to stable26

@icewind1991 icewind1991 merged commit 36835b7 into master Mar 24, 2023
@icewind1991 icewind1991 deleted the setup-user-onetime-before-mounts branch March 24, 2023 15:45
This was referenced Mar 24, 2023
Closed
Merged
@Pytal
Copy link
Member

Pytal commented Mar 28, 2023

Backportable to stable24 @icewind1991?

@Pytal
Copy link
Member

Pytal commented Mar 28, 2023

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @blizzz @Pytal @skjnldsv @come-nc