-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix unencrypted_size for folders when scanning the filesystem with encryption enabled #36857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
68d71cd to
5d71368
Compare
|
is this related / should this be linked with #25283 which has the whole discussion about unencrypted_size ? also there might be people there who could test this PR ? |
|
Any plans to merge and backport this to 25 @icewind1991 @come-nc ? |
…cryption enabled Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…t are left Signed-off-by: Robin Appelman <[email protected]>
1bcae22 to
06a1bd0
Compare
Signed-off-by: Robin Appelman <[email protected]>
06a1bd0 to
5267a74
Compare
|
/backport to stable26 |
|
/backport to stable25 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable26 |
To test:
setup an instance with encryption
create folder
testand write some files into it"accidentally" mess up the
unencrypted_sizefor the folder withupdate oc_filecache set unencrypted_size = 100 where name = 'test';run
occ files:scan --allin an attempt to repair itcheck if the folder size is reported correctly