Convert tag id to number (closing #35645)

[R0Wi]

• Resolves: File automated tagging - cannot select or use any tags as the conditions #35645

Summary

Did some research to help fixing R0Wi-DEV/workflow_ocr#179 and found out, that the NC Vue component for system tags expect numeric ids as values (either a single tag id or an array of tag ids which are selected). The server API for workflows deliveres the system tag ids as strings:

The temporary fix is to convert them on clientside into integers.

TODO

• Investigate why this error was introduced in NC25

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[artonge]

Hello @R0Wi,

Could you set a proper name to the issue and commit ?

The issue is that the values are saved in a generic string column in the DB. So they are returned as string by the API, as is it not possible to know in which type to cast them.

Your solution seem fine to me :)

[R0Wi]

Could you set a proper name to the issue and commit ?

Done ✔️

The issue is that the values are saved in a generic string column in the DB. So they are returned as string by the API, as is it not possible to know in which type to cast them.

Yes already spotted this but I wondered why the problem came with NC 25 since I think there hasn't been changed much in this area? Maybe an update of the NC Vue components is responsible for this.

[artonge]

Thanks :)

Not sure.

Worth noting that we recently moved to a new select component: #36754 so it might be useful to check if the bug still occurs with it.

[R0Wi]

According to https://github.com/nextcloud/nextcloud-vue/blob/1ed5694799d108cc03e287c2215b14e56d7c4df5/src/components/NcSelectTags/NcSelectTags.vue#L241 and the logic there, the component still expects the passed value prop to be of type Number (or number-array in case of multiselect). Comparing that to the value prop of the current FileSystemTag.vue, I think we still need to convert from the workflowengine value representation (string) to the one expected by the NcSelectTags component (number).

[R0Wi]

/backport stable25

[R0Wi]

@szaimen any chance to get this backported to NC 25?

[szaimen]

/backport to stable25