fix(files): Fix controller setup for guests

[nickvergessen]

Log

cat /var/www/data/nextcloud.log | grep "TagService::__construct" | wc -l
296

Details

{
  "reqId": "DvqdkPlTS0BENDuqRSIi",
  "level": 3,
  "time": "2023-02-28T14:24:35+00:00",
  "remoteAddr": "…",
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/apps/files/api/v1/stats",
  "message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php on line 109",
  "userAgent": "…",
  "version": "26.0.0.7",
  "exception": {
    "Exception": "TypeError",
    "Message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php on line 109",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 109,
        "function": "__construct",
        "class": "OCA\\Files\\Service\\TagService",
        "type": "->",
        "args": [
          [
            "OC\\User\\Session"
          ],
          [
            "OC\\Activity\\Manager"
          ],
          null,
          null,
          [
            "OC\\EventDispatcher\\SymfonyAdapter"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 171,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 122,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 138,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 487,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 465,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 65,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 88,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 171,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 122,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 138,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 487,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 465,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 65,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/AppFramework/App.php",
        "line": 148,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/Route/Router.php",
        "line": 315,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "APIController",
          "getStorageStats",
          "*** sensitive parameters replaced ***",
          [
            "files.API.getStorageStats"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/apps/files/api/v1/stats"
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/var/www/cloud.nextcloud.com/nextcloud/apps/files/lib/Service/TagService.php",
    "Line": 59,
    "CustomMessage": "--"
  }
}

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

/backport to stable26

[solracsf]

@nickvergessen any objection to backporting to 25?

[nickvergessen]

Not there yet. Let's see after #37826

[solracsf]

Ok, this was mainly because of #3376