Skip to content

Wrap URL string in quotes to avoid escaping issues #37020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niloc132 wants to merge 3 commits into from
Closed

Wrap URL string in quotes to avoid escaping issues #37020

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3375dc4
Wrap URL string in quotes to avoid escaping issues
niloc132 Mar 2, 2023
bbb00de
Review feedback, using template literals instead of concat
niloc132 Mar 2, 2023
56e6b50
Also modify the original html template
niloc132 Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review feedback, using template literals instead of concat 
Signed-off-by: Colin Alworth <[email protected]>
  • Loading branch information
@niloc132
niloc132 committed Mar 2, 2023
commit bbb00de02f0b44f34aeca7849af280d25f56b2e5
2 changes: 1 addition & 1 deletion core/src/OC/dialogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ const Dialogs = {
var previewUrl = OC.generateUrl('/core/preview.png?') + $.param(urlSpec)
img.onload = function() {
if (img.width > 5) {
$row.find('td.filename').attr('style', 'background-image:url(\"' + previewUrl + '\")')
$row.find('td.filename').attr('style', `background-image: url("${previewUrl}")`);
}
}
img.src = previewUrl
Expand Down