Add distraction free backgrounds for Nextcloud 26 #37028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan C. Borchardt <[email protected]>
jancborchardt
added
design
jancborchardt
requested review from
AndyScherzinger,
jospoortvliet,
juliusknorr,
karlitschek,
nimishavijay and
skjnldsv
Member
Author
|
stable26 doesn’t seem to exist yet, so not requesting a backport yet. |
Member
|
Nice +1 |
nimishavijay
approved these changes
Mar 3, 2023
Member
|
/backport to stable26
Now it does 😉 |
skjnldsv
approved these changes
Mar 3, 2023
skjnldsv
added
4. to release
|
The backport to stable26 failed. Please do this backport manually. |
1 similar comment
|
The backport to stable26 failed. Please do this backport manually. |
Member
|
/backport to stable26 |
Member
|
We're so close to master, why would it fail! 🤔 |
Member
|
Aaah! Good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding 4 distraction free backgrounds for Nextcloud 26. 2 lean more towards being used with the light theme, 2 more towards the dark theme. They are already compressed and each only around 600 kB.
Also added clear guidelines about the backgrounds for the future.
Please review @juliushaertl @skjnldsv @karlitschek @nimishavijay
Demo with light theme
Backgrounds-lightmode.mp4
Demo with dark theme
Backgrounds-darkmode.mp4
Checklist