Skip to content

Performance of WebDAV search requests with many shared files #37061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starypatyk wants to merge 8 commits into from
Closed

Performance of WebDAV search requests with many shared files #37061

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51b8e53
Use SQL IN operator for single file shares
starypatyk Mar 7, 2023
f4486d9
Code scanning / Psalm
starypatyk Mar 7, 2023
e063d9f
DIagnostic logging
starypatyk Jul 6, 2023
7814687
Alternative approach - refactor generated filter
starypatyk Jul 11, 2023
f649864
Fix incorrect assumption in checkStorageAndPathFilter
starypatyk Jul 12, 2023
5e1e692
Small refactoring and code clean-up
starypatyk Jul 13, 2023
2987c0d
psalm false positive
starypatyk Jul 13, 2023
f86dab9
Remove forgotten debug logging
starypatyk Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
psalm false positive 
Signed-off-by: Dariusz Olszewski <[email protected]>
  • Loading branch information
@starypatyk
starypatyk committed Jul 14, 2023
commit 2987c0d290c5e4b535b1f4173c3ca57c3b0fc6c4
2 changes: 2 additions & 0 deletions lib/private/Files/Cache/QuerySearchHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ private function checkStorageAndPathFilter(ISearchOperator $operator, array &$st
$a = $operator->getArguments()[0];
$b = $operator->getArguments()[1];
if ($this->isCompareEqual($a, "storage") && $this->isCompareEqual($b, "path")) {
/** @psalm-suppress UndefinedInterfaceMethod */
$storage = $a->getValue();
/** @psalm-suppress UndefinedInterfaceMethod */
$path = $b->getValue();
\OC::$server->getLogger()->debug("QuerySearchHelper::checkStorageAndPathFilter: storage=" . $storage . " " . "path=" . $path);
Copy link
Contributor

@come-nc come-nc Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\OC::$server->getLogger()->debug("QuerySearchHelper::checkStorageAndPathFilter: storage=" . $storage . " " . "path=" . $path);
$this->logger->debug("QuerySearchHelper::checkStorageAndPathFilter: storage=" . $storage . " " . "path=" . $path);

Copy link
Contributor Author

@starypatyk starypatyk Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove the logging. This was useful during development, quite unlikely to be useful in the future. Removed in f86dab9

$storageToPathsMap[$storage][] = $path;
Expand Down