Skip to content

Check free space only if source exists and is dir #37062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 2 commits into from
Apr 21, 2023
Merged

Check free space only if source exists and is dir #37062

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ac065f
Fix free space problems
solracsf Mar 6, 2023
28231ae
Add function_exists() check
solracsf Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix free space problems 
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf
solracsf authored Mar 6, 2023
commit 9ac065fb923d0918568eaba375f0669325b08443
2 changes: 1 addition & 1 deletion lib/private/Files/Storage/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ public function free_space($path) {
// disk_free_space doesn't work on files
$sourcePath = dirname($sourcePath);
}
$space = function_exists('disk_free_space') ? disk_free_space($sourcePath) : false;
$space = is_dir($sourcePath) ? disk_free_space($sourcePath) : false;
if ($space === false || is_null($space)) {
return \OCP\Files\FileInfo::SPACE_UNKNOWN;
}
Expand Down