Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 10, 2023

Summary

Hide download on public share links should only hide the download file action but others should still be available

Checklist

@juliusknorr juliusknorr requested review from a team, Pytal, skjnldsv and szaimen and removed request for a team March 10, 2023 08:53
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Mar 10, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27 milestone Mar 10, 2023
@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr
Copy link
Member Author

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@juliusknorr juliusknorr force-pushed the bugfix/noid/hide-download-actions branch from ea19915 to 9d74ea0 Compare March 13, 2023 11:51
@szaimen szaimen merged commit 5918591 into master Mar 14, 2023
@szaimen szaimen deleted the bugfix/noid/hide-download-actions branch March 14, 2023 12:14
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants