Skip to content

[stable26] invalidate existing tokens when deleting an oauth client #37230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 10 commits into from
Jun 15, 2023
Merged

[stable26] invalidate existing tokens when deleting an oauth client #37230

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f8f2d2
invalidate existing tokens when deleting an oauth client
individual-it Nov 11, 2022
19bb66a
public interface to invalidate tokens of user
individual-it Nov 21, 2022
aae3ff6
adjust SettingsController tests
individual-it Nov 22, 2022
774cdf5
unit tests for Manager::invalidateTokensOfUser
individual-it Nov 22, 2022
3e1e6f1
added @since tag
individual-it Nov 22, 2022
57c7b73
autoloaderchecker
individual-it Jan 6, 2023
dcab216
move mocks into private variables
individual-it Jan 9, 2023
cb005f6
invalidate oauth2 tokens only for seen users
individual-it Mar 17, 2023
67bba35
expect invalidateTokensOfUser only be called for seen users
individual-it May 19, 2023
40dcc08
adjust @since annotation
blizzz Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unit tests for Manager::invalidateTokensOfUser 
Signed-off-by: Artur Neumann <[email protected]>
  • Loading branch information
@individual-it
individual-it committed May 19, 2023
commit 774cdf5e9001351a06963211a0fca92b67975e48
44 changes: 44 additions & 0 deletions tests/lib/Authentication/Token/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,4 +355,48 @@ public function testUpdatePasswords() {

$this->manager->updatePasswords('uid', 'pass');
}

public function testInvalidateTokensOfUserNoClientName() {
$t1 = new PublicKeyToken();
$t2 = new PublicKeyToken();
$t1->setId(123);
$t2->setId(456);

$this->publicKeyTokenProvider
->expects($this->once())
->method('getTokenByUser')
->with('theUser')
->willReturn([$t1, $t2]);
$this->publicKeyTokenProvider
->expects($this->exactly(2))
->method('invalidateTokenById')
->withConsecutive(
['theUser', 123],
['theUser', 456],
);
$this->manager->invalidateTokensOfUser('theUser', null);
}

public function testInvalidateTokensOfUserClientNameGiven() {
$t1 = new PublicKeyToken();
$t2 = new PublicKeyToken();
$t3 = new PublicKeyToken();
$t1->setId(123);
$t1->setName('Firefox session');
$t2->setId(456);
$t2->setName('My Client Name');
$t3->setId(789);
$t3->setName('mobile client');

$this->publicKeyTokenProvider
->expects($this->once())
->method('getTokenByUser')
->with('theUser')
->willReturn([$t1, $t2, $t3]);
$this->publicKeyTokenProvider
->expects($this->once())
->method('invalidateTokenById')
->with('theUser', 456);
$this->manager->invalidateTokensOfUser('theUser', 'My Client Name');
}
}