Replace custom tooltips with native ones and add description to all e… #37244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
ChristophWurst,
Pytal,
artonge and
come-nc
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable26 |
come-nc
approved these changes
Mar 15, 2023
artonge
approved these changes
Mar 16, 2023
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Can you explain shortly why is a title and a description needed ?
Contributor
Author
Of coarse. Well https://www.24a11y.com/2017/the-trials-and-tribulations-of-the-title-attribute/ We don't have LDAP integration (app) in out test instance and because of this i would leave it like this for now ;) |
Pytal
approved these changes
Mar 16, 2023
ChristophWurst
added
4. to release
…lements which have `title` Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
fix/37179-replace-custom-tooltips-with-native-ones
branch
from
603b7eb to
b698cb2
Compare
blizzz
approved these changes
Mar 16, 2023
JuliaKirschenheuter
deleted the
fix/37179-replace-custom-tooltips-with-native-ones
branch
This was referenced Mar 16, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom tooltips with native ones and add description to all elements which have
title.Summary
Make tooltips in LDAP wizard readable and accessible.
Before:
After:
Checklist