Skip to content

[stable25] fix(user-management): Fix deleting user in hidden group(s) #37267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Apr 11, 2023
Merged

[stable25] fix(user-management): Fix deleting user in hidden group(s) #37267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/settings/src/store/users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ const mutations = {
state.userCount-- // decrement Active Users count
user.groups.forEach(userGroup => {
const group = state.groups.find(groupSearch => groupSearch.id === userGroup)
if (!group) {
console.warn('User group ' + userGroup + ' does not exist during user removal')
return
}
Comment on lines +187 to +190
Copy link
Contributor

@artonge artonge Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would map and filter instead of this

Copy link
Contributor Author

@szaimen szaimen Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst could you have a look at the comment? Not sure if I can follow Louis' suggestion...

Copy link
Member

@ChristophWurst ChristophWurst Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets the same result of undefined. This is a backport. Let's leave it like the original PR and refactoring is desired one can clean up the code on master

group.usercount-- // decrement group total count
})
} else {
Expand Down
Loading