Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 16, 2023

Summary

Set aria-hidden and aria-labelledby attrs on icons for default shipped widgets

No visual changes.

Before:
Screenshot from 2023-03-16 14-18-34

After:
Screenshot from 2023-03-16 14-16-58

Checklist

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- for ids are kinda strange but probably fine here

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36908-set_aria-hidden-for-default-shipped_widgets-icons branch from 9a3aff9 to 4dfde35 Compare March 17, 2023 14:00
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36908-set_aria-hidden-for-default-shipped_widgets-icons branch from 8e74860 to b111c18 Compare March 20, 2023 09:24
@JuliaKirschenheuter JuliaKirschenheuter merged commit 76adf9b into master Mar 20, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36908-set_aria-hidden-for-default-shipped_widgets-icons branch March 20, 2023 12:05
@AndyScherzinger
Copy link
Member

/backport to stable26

@AndyScherzinger
Copy link
Member

/backport to stable25

@JuliaKirschenheuter
Copy link
Contributor Author

@AndyScherzinger i've posted backports 4 days ago ;) thanks for reminding

@AndyScherzinger
Copy link
Member

Yeah, weird thing is they aren't being picked up @JuliaKirschenheuter

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

7 participants