Skip to content

fix right-click menu for open locally #37295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szaimen wants to merge 1 commit into from
Closed

fix right-click menu for open locally #37295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/files/js/fileactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,15 +716,15 @@
displayName: function(context) {
var locked = context.$file.data('locked');
if (!locked) {
return t('files', 'Edit locally');
return t('files', 'Open locally');
Copy link
Member

@Pytal Pytal Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the wording from "Edit" to "Open" @jancborchardt?

}
},
mime: 'all',
order: -23,
icon: function(filename, context) {
iconClass: function(filename, context) {
Copy link
Contributor Author

@szaimen szaimen Mar 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pytal changing to iconClass seems to make it visible in the right-click menu. However I still need to find out how to add the icon-computer class then.

Copy link
Member

@Pytal Pytal Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding icon-computer which is the deprecated way, would probably be better to make it work with the icon property

Copy link
Contributor Author

@szaimen szaimen Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that this would need to be fixed in the horrible rightclick app and unfortunately I dont see an easy way to achieve this in there :/

@skjlndsv would it be fine for now to create a new icon-computer class until it gets rewritten with vue?

Copy link
Member

@Pytal Pytal Apr 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv 👆

var locked = context.$file.data('locked');
if (!locked) {
return OC.imagePath('files', 'computer.svg')
return 'icon-computer'
Copy link
Contributor Author

@szaimen szaimen Mar 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt seem to work yet...

}
},
permissions: OC.PERMISSION_UPDATE,
Expand Down
Binary file added core/img/actions/computer.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions core/img/actions/computer.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.