Skip to content

[stable26] Fix/36908 set aria hidden for default shipped widgets icons #37338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuliaKirschenheuter merged 1 commit into from
Mar 24, 2023
Merged

[stable26] Fix/36908 set aria hidden for default shipped widgets icons #37338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix description for icons in dashboard widgets 
Signed-off-by: julia.kirschenheuter <[email protected]>
(cherry picked from commit b111c18)
  • Loading branch information
@JuliaKirschenheuter
JuliaKirschenheuter committed Mar 22, 2023
commit 9df19366c9cf8f8a0121c622d4654951967efa1a
6 changes: 5 additions & 1 deletion apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@
<div v-for="panelId in layout" :key="panels[panelId].id" class="panel">
<div class="panel--header">
<h2>
<div :class="panels[panelId].iconClass" role="img" />
<div aria-labelledby="panel--header--icon--description"
aria-hidden="true"
:class="panels[panelId].iconClass"
role="img" />
{{ panels[panelId].title }}
</h2>
<span id="panel--header--icon--description" class="hidden-visually"> {{ t('dashboard', '"{title} icon"', { title: panels[panelId].title }) }} </span>
</div>
<div class="panel--content" :class="{ loading: !panels[panelId].mounted }">
<div :ref="panels[panelId].id" :data-id="panels[panelId].id" />
Expand Down
4 changes: 2 additions & 2 deletions dist/dashboard-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/dashboard-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.