fix: Avoid scrolling the #content wrapper container #37417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
Pytal,
artonge and
skjnldsv
and removed request for
a team
artonge
approved these changes
Mar 27, 2023
Member
|
This CSS fix seems to do the job 👍🏼 😊 |
juliusknorr
force-pushed
the
bugfix/scroll-firefox
branch
from
d470d98 to
260ea2f
Compare
Pytal
approved these changes
Mar 27, 2023
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/scroll-firefox
branch
from
260ea2f to
4724d1c
Compare
skjnldsv
reviewed
Mar 28, 2023
skjnldsv
added
4. to release
Member
Author
|
Failures unrelated. |
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes some cases where the
overflow:hidden;on the wrapping#contentcontainer has been scrolled automatically by Firefox depending on user interaction. This also happened when tapping through the richdocuments settings page for example.clipwill block scrolling (also programmatically) which makes more sense as#app-contentis the actual scroll container.Checklist