Skip to content

implemented Sorting of shares by title and then creation date #37470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamantaTarun wants to merge 3 commits into from
Closed

implemented Sorting of shares by title and then creation date #37470

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c79eac4
implemented Sorting of shares by title and then creation date
SamantaTarun Mar 29, 2023
dd84ec4
fixed lint issues
SamantaTarun Mar 29, 2023
28c9797
Update SharingTab.vue
SamantaTarun Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed lint issues 
Signed-off-by: Tarun Samanta <[email protected]>
  • Loading branch information
@SamantaTarun
SamantaTarun committed Mar 29, 2023
commit dd84ec4fea7f8bb5ed2a4ab3976eeb22479879d2
4 changes: 2 additions & 2 deletions apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export default {
this.$set(this.sharedWithMe, 'subtitle', t('files_sharing', 'this share just expired.'))
}
},

// .sort((a, b) => b.createdTime - a.createdTime)
/**
* Process the current shares data
* and init shares[]
Expand All @@ -259,7 +259,7 @@ export default {
// create Share objects and sort by newest
const shares = data.ocs.data
.map(share => new Share(share))
.sort((a.title.localeCompare(b.title) === 0 ? b.createdTime - a.createdTime : a.title.localeCompare(b.title)),)
.sort((a, b) => a.title.localeCompare(b.title) === 0 ? b.createdTime - a.createdTime : a.title.localeCompare(b.title))

this.linkShares = shares.filter(share => share.type === this.SHARE_TYPES.SHARE_TYPE_LINK || share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL)
this.shares = shares.filter(share => share.type !== this.SHARE_TYPES.SHARE_TYPE_LINK && share.type !== this.SHARE_TYPES.SHARE_TYPE_EMAIL)
Expand Down