Fix types for reading and writing config values #37507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
ChristophWurst,
come-nc,
miaulalala and
nickvergessen
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Create a new job and store the creation date | ||
| $this->jobList->add(ResetTokenBackgroundJob::class); | ||
| $this->config->setAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()); | ||
| $this->config->setAppValue('core', 'updater.secret.created', (string)$this->timeFactory->getTime()); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| $this->userManager = $userManager; | ||
| $this->setInterval( | ||
| \OC::$server->getConfig()->getAppValue( | ||
| (int)\OC::$server->getConfig()->getAppValue( |
Check notice
Code scanning / Psalm
DeprecatedMethod
provokateurin
force-pushed
the
fix/config-values-types
branch
from
28704a5 to
f6e8770
Compare
nickvergessen
approved these changes
Mar 31, 2023
ChristophWurst
approved these changes
Mar 31, 2023
provokateurin
force-pushed
the
fix/config-values-types
branch
2 times, most recently
from
21a6cad to
50ed0d9
Compare
come-nc
approved these changes
Apr 3, 2023
provokateurin
force-pushed
the
fix/config-values-types
branch
2 times, most recently
from
fe02954 to
a3edcbe
Compare
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
fix/config-values-types
branch
from
a3edcbe to
d9f8522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #37390
Checklist