Add type hints for mappers #37511
Merged
Add type hints for mappers #37511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
ChristophWurst,
come-nc,
miaulalala and
nickvergessen
ChristophWurst
approved these changes
Mar 31, 2023
come-nc
approved these changes
Apr 3, 2023
provokateurin
force-pushed
the
feature/type-mappers
branch
from
ac88154 to
a9a0a38
Compare
miaulalala
approved these changes
Apr 4, 2023
provokateurin
force-pushed
the
feature/type-mappers
branch
from
a9a0a38 to
131e852
Compare
ChristophWurst
approved these changes
Apr 6, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
ChangesMapper/Changes looks good now
provokateurin
force-pushed
the
feature/type-mappers
branch
from
131e852 to
594d470
Compare
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
feature/type-mappers
branch
from
594d470 to
b153340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #37390
Checklist