Ungroup placeholder css rules to prevent browsers from removing all rules
#37522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Pytal,
artonge and
szaimen
and removed request for
a team
Pytal
approved these changes
Apr 1, 2023
susnux
force-pushed
the
fix/css-placeholder-color
branch
from
c7f6791 to
80704dd
Compare
Contributor
Author
|
Rebased to resolve conflicts. /backport to stable26 |
susnux
added
4. to release
Member
|
/rebase |
Member
|
/backport to stable26 |
Member
|
/backport to stable25 |
susnux
force-pushed
the
fix/css-placeholder-color
branch
from
80704dd to
675dfb3
Compare
Contributor
Author
|
@solracsf rebased it manually :) |
szaimen
force-pushed
the
fix/css-placeholder-color
branch
from
675dfb3 to
08aae0f
Compare
Contributor
|
/compile amend / |
…emoving all rules When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1]. In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome, so the `::placeholder` rule is never applied. [1]: https://www.w3.org/TR/selectors-3/#grouping Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/css-placeholder-color
branch
from
08aae0f to
f8d558e
Compare
Contributor
|
CI failure unrelated |
1 task
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Contributor
Author
Manually done in #37829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated1.
In this case
::-ms-input-placeholderis unknown to Firefox and Chrome, so the::placeholderrule is never applied.Screenshots
See default color (
--color-text-main) is applied also for the placeholder on the before image, and note the missing::placeholderselector on the before image (on the "pseudo elements" section of the inspector).Checklist