Skip to content

Conversation

@jtrees
Copy link
Contributor

@jtrees jtrees commented Apr 5, 2023

Summary

Provides tests for the changes made in #37495 (thanks @joshtrichards).

Note: This is my first code contribution to nextcloud. Let me know if I should be doing something differently.

Checklist

@jtrees jtrees requested review from blizzz and come-nc April 5, 2023 10:20
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 5, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 5, 2023
@szaimen szaimen requested review from a team and icewind1991 and removed request for a team April 5, 2023 12:08
@blizzz
Copy link
Member

blizzz commented Apr 6, 2023

failing tests unrelated / temporary infra issue

@blizzz blizzz merged commit 1ac7a3f into nextcloud:master Apr 6, 2023
@welcome
Copy link

welcome bot commented Apr 6, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@jtrees jtrees deleted the add-some-tests-to-lost-controller branch April 6, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants