Skip to content

Refactors Command/Encryption/Enable.php to improve code readability. #37665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
May 23, 2023
Merged

Refactors Command/Encryption/Enable.php to improve code readability. #37665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactors core/Command/Encryption/Enable.php to improve code readabil… 
…ity.

Improves the readability of the "execute" method by using early returns and reducing the code indentation.

Signed-off-by: Faraz Samapoor <[email protected]>
  • Loading branch information
@fsamapoor
fsamapoor authored Apr 11, 2023
commit 8f4b20aaa172a262482d3884067d0fc8fb116064
22 changes: 11 additions & 11 deletions core/Command/Encryption/Enable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,18 @@ protected function execute(InputInterface $input, OutputInterface $output): int
if (empty($modules)) {
$output->writeln('<error>No encryption module is loaded</error>');
return 1;
} else {
$defaultModule = $this->config->getAppValue('core', 'default_encryption_module', null);
if ($defaultModule === null) {
$output->writeln('<error>No default module is set</error>');
return 1;
} elseif (!isset($modules[$defaultModule])) {
$output->writeln('<error>The current default module does not exist: ' . $defaultModule . '</error>');
return 1;
} else {
$output->writeln('Default module: ' . $defaultModule);
}
}
$defaultModule = $this->config->getAppValue('core', 'default_encryption_module', null);

Check notice

Code scanning / Psalm

NullArgument

Argument 3 of OCP\IConfig::getAppValue cannot be null, null value provided to parameter with type string
if ($defaultModule === null) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction

string does not contain null
$output->writeln('<error>No default module is set</error>');
return 1;
}
if (!isset($modules[$defaultModule])) {
$output->writeln('<error>The current default module does not exist: ' . $defaultModule . '</error>');
return 1;
}
$output->writeln('Default module: ' . $defaultModule);

return 0;
}
}