-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(files): better breakpoints and sidebar responsive design #37692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99886e4 to
06091d1
Compare
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from the screnshots/casts and the code looks good! :)
(but didnt test)
I agree, should we increase this to 768? (I could do the PR if you want) (would need to adjust https://github.com/nextcloud/nextcloud-vue/pull/2747/files) |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
06091d1 to
225d6e2
Compare
|
CI failure unrelated |
|

This uses 3 breakpoints for better visibility:
Files kinda had those (480 instead of 512), and I think it's alright like this. What do you think @jancborchardt ? Shall we push that to other apps too?
Without sidebar:
Peek.12-04-2023.18-41.mp4
With sidebar:
Peek.12-04-2023.18-42.mp4
Various screenshots: