Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 12, 2023

This uses 3 breakpoints for better visibility:

  • 1024
  • 768
  • 512

Files kinda had those (480 instead of 512), and I think it's alright like this. What do you think @jancborchardt ? Shall we push that to other apps too?

Without sidebar:

Peek.12-04-2023.18-41.mp4

With sidebar:

Peek.12-04-2023.18-42.mp4

Various screenshots:

Without sidebar With sidebar
1366 localhost_8080_index php_apps_files_trashbin localhost_8080_index php_apps_files_trashbin (1)
1024 localhost_8080_index php_apps_files_trashbin (3) localhost_8080_index php_apps_files_trashbin (2)
768 localhost_8080_index php_apps_files_trashbin (4) localhost_8080_index php_apps_files_trashbin (5)
512 localhost_8080_index php_apps_files_trashbin (7) localhost_8080_index php_apps_files_trashbin (6)

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 12, 2023

There is one thing I would change, is increasing the breakpoint of the Sidebar going full screen (512 at the moment). This would need a fix in the vue components. Otherwise you can have this:
image

@skjnldsv skjnldsv force-pushed the feat/resizeobserver-breakpoint-files branch from 99886e4 to 06091d1 Compare April 12, 2023 17:01
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from the screnshots/casts and the code looks good! :)
(but didnt test)

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2023

There is one thing I would change, is increasing the breakpoint of the Sidebar going full screen (512 at the moment). This would need a fix in the vue components.

I agree, should we increase this to 768? (I could do the PR if you want)

(would need to adjust https://github.com/nextcloud/nextcloud-vue/pull/2747/files)

@skjnldsv

This comment was marked as resolved.

Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the feat/resizeobserver-breakpoint-files branch from 06091d1 to 225d6e2 Compare April 13, 2023 06:08
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 13, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2023

CI failure unrelated

@szaimen szaimen merged commit bdf91ae into master Apr 13, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 13, 2023

There is one thing I would change, is increasing the breakpoint of the Sidebar going full screen (512 at the moment). This would need a fix in the vue components.

I agree, should we increase this to 768? (I could do the PR if you want)

(would need to adjust https://github.com/nextcloud/nextcloud-vue/pull/2747/files)

done in nextcloud-libraries/nextcloud-vue#3972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants