Skip to content

Fix opendir return type #37725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
provokateurin wants to merge 1 commit into from
Closed

Fix opendir return type #37725

provokateurin wants to merge 1 commit into from

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Apr 14, 2023 •
edited
Loading

Summary

Split out from #37390

IteratorDirectory::wrap has return type resource|bool so it needs to be adapted.

Checklist

@provokateurin provokateurin added this to the Nextcloud 27 milestone Apr 14, 2023
come-nc
come-nc requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes backward from #36836

@come-nc
Copy link
Contributor

come-nc commented Apr 17, 2023

IteratorDirectory::wrap has return type resource|bool so it needs to be adapted.

Already fixed in icewind1991/Streams#17

This was referenced May 3, 2023
Merged
Closed
Merged
@ChristophWurst ChristophWurst deleted the fix/opendir-return-type branch May 15, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc requested changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @come-nc @skjnldsv