chore(assets): Require scour 0.38.2 (Ubuntu LTS 22.04+) for SVG optimization #37763
+478
−547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
jancborchardt,
luka-nextcloud and
nimishavijay
jancborchardt
requested changes
Apr 19, 2023
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Added comments on 3 images I’m not sure we should touch – otherwise it looks good! :)
…ization Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/36014/require-scour-0.38.2-for-svg-optimization
branch
from
7be921d to
f82c3d7
Compare
come-nc
approved these changes
Apr 24, 2023
ChristophWurst
approved these changes
Apr 24, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Nit: squash the commits into one to keep our git history light
ChristophWurst
added
4. to release
jancborchardt
approved these changes
Apr 24, 2023
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
deleted the
techdebt/36014/require-scour-0.38.2-for-svg-optimization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist