Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Apr 19, 2023

Summary

array_unique returns a new array rather than mutating the original array in-place

Before After
["5","2","4","4","3","3","2","2","1","1"] ["5","2","4","3","1"]

Technically the array will not be made unique until the next time the user selects a tag but it’s probably not worth adding a background job for this as the existing frontend code still sorts the tags correctly

Checklist

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal added this to the Nextcloud 27 milestone Apr 19, 2023
@Pytal Pytal self-assigned this Apr 19, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2023
@Pytal Pytal merged commit c18a41a into master Apr 19, 2023
@Pytal Pytal deleted the fix/last-used branch April 19, 2023 18:52
@Pytal Pytal mentioned this pull request Apr 20, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants