Skip to content

[stable25] Ungroup placeholder css rules to prevent browsers from removing all rules #37829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Apr 20, 2023
Merged

[stable25] Ungroup placeholder css rules to prevent browsers from removing all rules #37829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/css/inputs.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/inputs.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 17 additions & 4 deletions core/css/inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,22 @@ label.infield {
overflow: hidden;
}

::placeholder,
::-ms-input-placeholder,
::-webkit-input-placeholder {
// when rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated.
// https://www.w3.org/TR/selectors-3/#grouping
// In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome
@mixin placeholder-style {
color: var(--color-text-maxcontrast);
font-size: var(--default-font-size);
font-size: var(--default-font-size);
}

::placeholder {
@include placeholder-style;
}

::-ms-input-placeholder {
@include placeholder-style;
}

::-webkit-input-placeholder {
@include placeholder-style;
}
12 changes: 10 additions & 2 deletions core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading