feat(BackgroundJobs): Allow preventing parallel runs for a job class #37835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
commented
Apr 20, 2023
marcelklehr
commented
Apr 20, 2023
nickvergessen
approved these changes
Apr 21, 2023
Member
|
you need to rebase on master to fix the red ci |
marcelklehr
force-pushed
the
feat/background-allow-parallel-runs
branch
from
4eb91d0 to
75a13f2
Compare
Member
Author
|
Didn't help. |
Member
|
Member
|
So time to rebase again |
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…Jobs Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
so Joas doesn't die Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/background-allow-parallel-runs
branch
from
75a13f2 to
5a7f023
Compare
Signed-off-by: Marcel Klehr <[email protected]>
come-nc
reviewed
Apr 24, 2023
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
come-nc
approved these changes
Apr 24, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
We have both TestJob.php and JobTest.php files in the same folder xD
Signed-off-by: Marcel Klehr <[email protected]>
Member
Author
|
Can we merge this? CI failure seems unlreated. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a setAllowParallelRuns() method to the BackgroundJob\Job abstract class in order to allow jobs to disallow parallel runs.
Checklist