Skip to content

[stable26] Check free space only if source exists and is dir #37873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 2 commits into from
May 12, 2023
Merged

[stable26] Check free space only if source exists and is dir #37873

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef8e76
Fix free space problems
solracsf Mar 6, 2023
e41eb52
Add function_exists() check
solracsf Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add function_exists() check 
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf @szaimen @icewind1991
2 people authored and icewind1991 committed May 12, 2023
commit e41eb529b8076917dd530d6d599da2f5e1ad43a0
2 changes: 1 addition & 1 deletion lib/private/Files/Storage/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ public function free_space($path) {
// disk_free_space doesn't work on files
$sourcePath = dirname($sourcePath);
}
$space = is_dir($sourcePath) ? disk_free_space($sourcePath) : false;
$space = (function_exists('disk_free_space') && is_dir($sourcePath)) ? disk_free_space($sourcePath) : false;
if ($space === false || is_null($space)) {
return \OCP\Files\FileInfo::SPACE_UNKNOWN;
}
Expand Down