[stable25] Do not override stored credentials when login in with SAML #37901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
3. to review
artonge
requested review from
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
icewind1991
approved these changes
Apr 24, 2023
Contributor
Author
|
/rebase |
Signed-off-by: Louis Chemineau <[email protected]>
When login in with SAML, the password from `$event->getPassword()` is `null`. This PR makes sure that this `null` value won't be used to override the stored password even though it is different. This PR also allow for the password and user to be updated even though they were not set before. Signed-off-by: Louis Chemineau <[email protected]>
nextcloud-command
force-pushed
the
backport/stable25/artonge/fix/dont_override_stored_credentials_with_saml
branch
from
1399e74 to
30e78f3
Compare
Pytal
approved these changes
Apr 26, 2023
artonge
deleted the
backport/stable25/artonge/fix/dont_override_stored_credentials_with_saml
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #37717