Skip to content

Fix multiple LDAP configuration support by fixing AccessFactory #37903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 3 commits into from
May 2, 2023
Merged

Fix multiple LDAP configuration support by fixing AccessFactory #37903

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
429db14
Fix multiple LDAP configuration support by fixing AccessFactory
come-nc Apr 24, 2023
802363f
Adapt Sync job tests to the constructor change
come-nc Apr 27, 2023
9679553
Add comment about Manager instance not being shared
come-nc Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comment about Manager instance not being shared 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Apr 27, 2023
commit 967955358c2693aafb1e43795b09cf24e460929b
1 change: 1 addition & 0 deletions apps/user_ldap/lib/AccessFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public function __construct(
}

public function get(Connection $connection): Access {
/* Each Access instance gets its own Manager instance, see OCA\User_LDAP\AppInfo\Application::register() */
return new Access(
$connection,
$this->ldap,
Expand Down