fix(contactsinteraction): Read, update or insert in DB transaction #37933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transaction guarantees there are no two concurrent inserts for the same interaction. Signed-off-by: Christoph Wurst <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($event->getFederatedCloudId() !== null) { | ||
| $contact->setFederatedCloudId($event->getFederatedCloudId()); | ||
| } | ||
| $contact->setLastContact($this->timeFactory->getTime()); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| $event->getFederatedCloudId() | ||
| ); | ||
| if (!empty($existing)) { | ||
| $now = $this->timeFactory->getTime(); |
Check notice
Code scanning / Psalm
DeprecatedMethod
Signed-off-by: Christoph Wurst <[email protected]>
JohannesGGE
approved these changes
May 2, 2023
st3iny
added
4. to release
8 tasks
This was referenced May 3, 2023
Merged
Closed
Merged
ChristophWurst
deleted the
fix/contactsinteraction/transactional-read-update-insert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The transaction guarantees there are no two concurrent inserts for the same interaction.
I have not seen a conflict in production. I just noticed that this code is prone to fail in rare cases.
This is best reviewed as https://github.com/nextcloud/server/pull/37933/files?w=1
TODO
Checklist