Skip to content

Do not allow to toggle between password and text in sharing #37954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
May 10, 2023
Merged

Do not allow to toggle between password and text in sharing #37954

artonge merged 1 commit into from
May 10, 2023

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 27, 2023 •
edited
Loading

@artonge artonge added this to the Nextcloud 27 milestone Apr 27, 2023
@artonge artonge requested a review from a team April 27, 2023 13:36
@artonge artonge self-assigned this Apr 27, 2023
@artonge artonge requested review from Pytal, skjnldsv and szaimen and removed request for a team April 27, 2023 13:36
@artonge artonge mentioned this pull request Apr 27, 2023
Merged
@szaimen
Copy link
Contributor

szaimen commented Apr 27, 2023

Since this needs a vue lib update, lets convert it into a draft...

@szaimen szaimen marked this pull request as draft April 27, 2023 13:38
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@artonge
Copy link
Contributor Author

artonge commented May 9, 2023

/rebase

@artonge artonge marked this pull request as ready for review May 9, 2023 09:40
@artonge
Copy link
Contributor Author

artonge commented May 9, 2023

/rebase

@artonge artonge force-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch 2 times, most recently from 62e8117 to 3bd2884 Compare May 9, 2023 15:23
@artonge artonge enabled auto-merge May 9, 2023 15:24
@artonge
Do not allow to toggle between password and text in sharing
6faf8b8 
This does not makes sense as we do not have the clear text value.

Signed-off-by: Louis Chemineau <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch from 3bd2884 to 12fd72d Compare May 9, 2023 15:37
@artonge artonge force-pushed the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch from 12fd72d to 6faf8b8 Compare May 9, 2023 15:41
@artonge
Copy link
Contributor Author

artonge commented May 10, 2023

CI failure unrelated

@artonge artonge disabled auto-merge May 10, 2023 08:23
@artonge artonge merged commit 5993a4b into master May 10, 2023
@artonge artonge deleted the artonge/fix/do_not_allow_to_show_pwd_in_sharing branch May 10, 2023 08:23
@skjnldsv skjnldsv modified the milestones: Nextcloud 28, Nextcloud 27 May 10, 2023
This was referenced Jul 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug feature: sharing javascript

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

5 participants

@artonge @szaimen @skjnldsv @Pytal