Skip to content

use more efficient tag retrieval on DAV report request #37969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 14 commits into from
Jun 28, 2023
Merged

use more efficient tag retrieval on DAV report request #37969

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
58f7fd2
use efficient tag retrieval on DAV report request
blizzz Apr 28, 2023
b0d1cf5
fix: change if with conditionless else to switch; and a parameter value
blizzz May 11, 2023
783e32a
fix: favorites view and universal search against tags
blizzz May 11, 2023
be50bd1
fix: ensure searchBySystemTag() is available
blizzz May 11, 2023
ddb65be
chore: cleanup unused code
blizzz May 11, 2023
30028bb
fix: no search when LazyFolder was provided
blizzz May 12, 2023
221562d
feat: add searchBySystemTag as PHP API
blizzz Jun 7, 2023
29f59a5
fix: search with more than one search tags
blizzz Jun 2, 2023
49db546
fix: include invisible tags for admins
blizzz Jun 15, 2023
a0f9556
fix: cominbation of small fixes
blizzz Jun 21, 2023
27f6f86
fix: obey offset and limit for results from favs and circles
blizzz Jun 21, 2023
a0b6834
fix: use array_unitersect against objects
blizzz Jun 21, 2023
00b396a
refactor: save unnecessary method_exists
blizzz Jun 21, 2023
d948710
fix: cannot apply limit+offset on multi-tag-search
blizzz Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add searchBySystemTag as PHP API 
Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz
blizzz committed Jun 21, 2023
commit 221562d45d9ed816dfe28eafe5e57f3812821a88
4 changes: 4 additions & 0 deletions lib/private/Files/Node/LazyFolder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,10 @@ public function searchByTag($tag, $userId) {
return $this->__call(__FUNCTION__, func_get_args());
}

public function searchBySystemTag(string $tagName, string $userId, int $limit = 0, int $offset = 0) {
return $this->__call(__FUNCTION__, func_get_args());
}

/**
* @inheritDoc
*/
Expand Down
10 changes: 10 additions & 0 deletions lib/public/Files/Folder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ public function searchByMime($mimetype);
*/
public function searchByTag($tag, $userId);

/**
* search for files by system tag
*
* @param string|int $tag tag name
* @param string $userId user id to ensure access on returned nodes
* @return \OCP\Files\Node[]
* @since 28.0.0
*/
public function searchBySystemTag(string $tagName, string $userId, int $limit = 0, int $offset = 0);

/**
* get a file or folder inside the folder by it's internal id
*
Expand Down