fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader #38065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
a team,
ArtificialOwl,
come-nc,
nfebe and
nickvergessen
and removed request for
a team
4 tasks
tcitworld
force-pushed
the
fix-result-mimetype-loader
branch
from
f584c5f to
a73e15f
Compare
nickvergessen
approved these changes
May 4, 2023
come-nc
reviewed
May 4, 2023
come-nc
approved these changes
May 4, 2023
…MimeType Loader Also, only return the ID from the transaction as the mimetype string is already used from the function argument value Fixes https://github.com/nextcloud/server/pull/35744/files#r1184644610 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
fix-result-mimetype-loader
branch
from
a73e15f to
3754668
Compare
come-nc
approved these changes
May 4, 2023
Contributor
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/nextcloud/server/pull/35744/files#r1184644610
Checklist