Skip to content

Sort tags #38066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tobiasKaminsky wants to merge 1 commit into from
Closed

Sort tags #38066

tobiasKaminsky wants to merge 1 commit into from

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented May 4, 2023

Summary

sorts tags before returning via webdav

Checklist

@tobiasKaminsky tobiasKaminsky added the 3. to review Waiting for reviews label May 4, 2023
@tobiasKaminsky tobiasKaminsky requested a review from icewind1991 May 4, 2023 10:36
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 4, 2023
This was referenced May 4, 2023
Closed
Closed
@blizzz
Copy link
Member

blizzz commented May 4, 2023 •
edited
Loading

This should fail with PHP Warning: Array to string conversion in php shell code on line x

P.S.: Or rather PHP Warning: Uncaught Error: Object of class SystemTag could not be converted to string in …

skjnldsv
skjnldsv requested changes May 4, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @blizzz comment

@skjnldsv
Copy link
Member

skjnldsv commented May 4, 2023

Will push fix

@skjnldsv
Copy link
Member

skjnldsv commented May 4, 2023

Done

@skjnldsv skjnldsv requested a review from blizzz May 4, 2023 11:19
@blizzz blizzz mentioned this pull request May 4, 2023
Merged
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
@blizzz
Copy link
Member

blizzz commented May 4, 2023

@skjnldsv in parallel i did #38067 as alternative

@tobiasKaminsky @icewind1991
Sort tags
a86b6a0 
Signed-off-by: tobiasKaminsky <[email protected]>
@icewind1991
Copy link
Member

icewind1991 commented May 4, 2023

#38067 is probably the better place to do the sorting

@skjnldsv skjnldsv closed this May 4, 2023
@skjnldsv skjnldsv deleted the sortTags branch May 4, 2023 11:28
github-advanced-security[bot]
github-advanced-security bot found potential problems May 4, 2023
View reviewed changes
apps/dav/lib/SystemTag/SystemTagList.php
Comment on lines +62 to +64
usort($this->tags, function(SystemTag $a, SystemTag $b) {
return strnatcmp($a->getName(), $b->getName());
});

Check notice

Code scanning / Psalm

ArgumentTypeCoercion

Type OCP\SystemTag\ISystemTag should be a subtype of OC\SystemTag\SystemTag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: tags

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

6 participants

@tobiasKaminsky @blizzz @skjnldsv @icewind1991 @AndyScherzinger