Skip to content

Add an occ command to scan files for legacy file key in use and get rid of those #38080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 7 commits into from
May 15, 2023
Merged

Add an occ command to scan files for legacy file key in use and get rid of those #38080

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5663f9b
Add an occ command to scan files for legacy file key in use and get r…
come-nc May 4, 2023
146284f
Fix fopen mode
come-nc May 4, 2023
c9c49bf
Log failures to delete legacy file key
come-nc May 4, 2023
725403c
Copy and move files to migrate them to the new key
come-nc May 9, 2023
36fc5dc
Copy data back instead of renaming to avoid changing the fileid
come-nc May 11, 2023
a92028f
Rename command to drop-legacy-filekey and remove comment about legacy…
come-nc May 11, 2023
4910888
Add fclose on opened resources
come-nc May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix fopen mode 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed May 4, 2023
commit 146284f170d3da88709ec76007f6f7b5ad975d39
11 changes: 8 additions & 3 deletions apps/encryption/lib/Command/FixLegacyFileKey.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,17 @@ private function scanFolder(OutputInterface $output, string $folder): bool {
/* If that did not throw and filekey is not empty, a legacy filekey is used */
$clean = false;
$output->writeln($path . ' is using a legacy filekey, migrating');
$file = $this->rootView->fopen($path, 'w+');
$file = $this->rootView->fopen($path, 'r+');
if ($file) {
fwrite($file, '');
$firstByte = fread($file, 1);
if ($firstByte === false) {
$output->writeln('<error>failed to read ' . $path . '</error>');
continue;
}
fwrite($file, $firstByte);
fclose($file);
} else {
$output->writeln('<error>failed to open' . $path . '</error>');
$output->writeln('<error>failed to open ' . $path . '</error>');
}
}
}
Expand Down