Fix error on delete in ChunkingV2Plugin #38083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return true; | ||
| } | ||
|
|
||
| [$storage, $storagePath] = $this->getUploadStorage($this->uploadPath); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
juliusknorr
approved these changes
May 5, 2023
Member
|
Thanks for the pull request, could you add a signoff message to your commit to fix the DCO check? https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work has more details about taht. |
Signed-off-by: Lorenzo Taanganelli <[email protected]>
tanganellilore
force-pushed
the
fix_delete_ChunkingV2Plugin
branch
from
e34b41b to
592f2ec
Compare
tanganellilore
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
Contributor
Author
|
@juliushaertl change message on commit close this pull request. Sorry for that |
Member
|
Hm I could not do that, maybe you can open a fresh one? |
Contributor
Author
|
i publish new one: #38100 DCO continue to not pass, but I have added my email and username (official one) |
Contributor
Author
|
should be fixed now.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix the error on "delete" call when is used and storage class that is not
IChunkedFileWrite::class.Implementation is the same of other "before" method
TODO
Checklist